Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct behavior when other libraries override http.get and http.request #1868

Merged
merged 3 commits into from Feb 7, 2020
Merged

fix: Correct behavior when other libraries override http.get and http.request #1868

merged 3 commits into from Feb 7, 2020

Conversation

paulmelnikow
Copy link
Member

Ref newrelic/node-newrelic#316

Thanks @kennethaasan for finding this fix!

Fix #1836
Closes #1853

@paulmelnikow paulmelnikow mentioned this pull request Feb 6, 2020
Closed
@paulmelnikow
Copy link
Member Author

Hmmm, not sure why the Node 8 build isn't running.

@kennethaasan
Copy link

@paulmelnikow, Thanks for bringing this together!

It looks like the npm version that ships with Node 8 is behaving weird compared to 10 and 12. This problem is not related to this PR though :/

@kennethaasan kennethaasan mentioned this pull request Feb 7, 2020
Closed
@paulmelnikow
Copy link
Member Author

@gr2m I'm thinking I will go ahead and merge this even thought the Node 8 CI isn't running. We should drop support for Node 8; I'll open an issue for that.

gr2m
gr2m approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@gr2m
Copy link
Member

gr2m commented Feb 7, 2020

Hold on, I didn't check the code changes or the CI (gotta run), but if this breaks usage in Node 8, and the current version of nock supports Node 8 officially, we should not just ship it, but release a new breaking version

@mastermatt
Copy link
Member

Node 8 is failing because of a dev sub dep, I don't think it's related to this.

npm ERR! 404 Not Found - GET https://registry.npmjs.org/@semantic-release/commit-analyzer/-/commit-analyzer-7.0.0-beta-.2.tgz
npm ERR! 404
npm ERR! 404 '@semantic-release/commit-analyzer@7.0.0-beta-.2' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)

I had to completely reset my deps and lock file when I worked on a PR earlier today.

@gr2m
Copy link
Member

gr2m commented Feb 7, 2020

Got it, ship it then :) semantic-release no longer supports Node 8

@paulmelnikow paulmelnikow merged commit 22e2fca into master Feb 7, 2020
@paulmelnikow paulmelnikow deleted the newrelic-fix branch February 7, 2020 23:29
@weekly-digest weekly-digest bot mentioned this pull request Feb 9, 2020
Closed
@paulmelnikow paulmelnikow mentioned this pull request Feb 10, 2020
Closed
@nockbot
Copy link
Collaborator

nockbot commented Feb 10, 2020

🎉 This PR is included in version 11.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

@mastermatt mastermatt mastermatt approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking expected Node behaviour for http.get
5 participants
@paulmelnikow @kennethaasan @gr2m @mastermatt @nockbot