#1836 fixes expected Node behaviour for http.get #1837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for opening this! Could you add a test for the correct behavior? |
|
Please check now |
mastermatt
approved these changes
Jan 10, 2020
| t.equal(reqSpy.called, false) | ||
| scope.done() | ||
| http.request = origHttpReq | ||
| t.end() |
There was a problem hiding this comment.
When I run this test without the change, I get a TypeError. Is that the expected behavior?
Could you clarify how this test exercises the bug from #1836?
There was a problem hiding this comment.
I added http.request to the spy function and now the test is failing on assertion instead of TypeError.
The test makes sure http.request is not called when using http.get. That fixes #1836
tests/test_common.js
Outdated
| res.on('end', () => { | ||
| t.equal(reqSpy.called, false) | ||
| scope.done() | ||
| http.request = origHttpReq |
There was a problem hiding this comment.
For safety, could you move this cleanup code into a t.on('end', () => {}) callback?
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com>
* chore(package): update eslint-plugin-node to version 11.0.0 * chore(package): update lockfile package-lock.json Co-authored-by: Paul Melnikow <github@paulmelnikow.com>
* chore(package): update nyc to version 15.0.0 * chore(package): update lockfile package-lock.json Co-authored-by: Paul Melnikow <github@paulmelnikow.com>
* chore(package): update sinon to version 8.0.0 * chore(package): update lockfile package-lock.json Co-authored-by: Paul Melnikow <github@paulmelnikow.com>
* chore(package): update dtslint to version 2.0.0 * chore(package): update lockfile package-lock.json * Update to 2.0.2 * Update lockfile Co-authored-by: Paul Melnikow <github@paulmelnikow.com>
Fix a regression in 11.7.1 due to Jest having different globals: jestjs/jest#2549. Check functions using typeof instead of instanceof.
kennethaasan
force-pushed
the
node-http
branch
2 times, most recently
from
60ea3d6
to
628b9d7
Compare
|
Sorry, I fucked up git when trying to rebase. I made a new clean PR at #1853 Closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1836