Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): pass socket to IncomingMessage constructor. #1743

Merged
merged 1 commit into from
Oct 15, 2019
Merged

refactor(router): pass socket to IncomingMessage constructor. #1743

merged 1 commit into from
Oct 15, 2019

Commits on Oct 13, 2019

  1. refactor(router): pass socket to response constructor. 

    Passing the socket from the request to the `IncomingMessage` is what
happens in native Node. Using a dummy `EventEmitter` then tacking the
socket onto the response later is kludge from historical tech-debt that
can now safely be cleaned up.
    @mastermatt
    mastermatt committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    dd5ccde View commit details
    Browse the repository at this point in the history