chore: Fix the goreleaser workflow #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieomylnieja
requested review from
skrolikiewicz and
daniel-zelazny
as code owners
nieomylnieja
changed the title
n9-machine-user
added
chore
piotrkwarcinski
approved these changes
Mar 1, 2024
nieomylnieja
added a commit
to nobl9/sloctl
that referenced
this pull request
Mar 4, 2024
## Motivation Use GH environments and a no-op step along with `needs` chaining to achieve a flow where both QA and management have to approve the release. I also parametrized e2e tests, we might want to trigger these tests from other places too. I also fixed the issue with Goreleaser, ref: nobl9/terraform-provider-nobl9#182
BSski
pushed a commit
to nobl9/sloctl
that referenced
this pull request
May 7, 2024
## Motivation Use GH environments and a no-op step along with `needs` chaining to achieve a flow where both QA and management have to approve the release. I also parametrized e2e tests, we might want to trigger these tests from other places too. I also fixed the issue with Goreleaser, ref: nobl9/terraform-provider-nobl9#182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Goreleaser is not interpreting the correct tag, here's a related issue: goreleaser/goreleaser-action#255. The workaround is to set an env var
GORELEASER_CURRENT_TAG.I also sneaked some minor changes to how acceptance tests are run so that we can provide it with ref to run against.