Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PC-11815 add budget adjustments terraform support #175

Merged
merged 31 commits into from
May 14, 2024
Merged

feat: PC-11815 add budget adjustments terraform support #175

merged 31 commits into from
May 14, 2024

Conversation

kubaceg
Copy link
Contributor

@kubaceg kubaceg commented Feb 22, 2024 •
edited

Motivation

Add support for the new BudgetAdjustment kind.

Release Notes

New BudgetAdjustment kind which allows customers to schedule recurring future events that should be excluded from the Error Budget calculations in their SLOs. This PR introduces new budget_adjustment resource.

@n9-machine-user n9-machine-user added breaking-change Any kind of non-backwards compatible change go Pull requests that update Go code release-notes labels Feb 22, 2024
@kubaceg kubaceg changed the title PC-11815 add budget adjustments terraform support feat: PC-11815 add budget adjustments terraform support Feb 22, 2024
@n9-machine-user n9-machine-user added enhancement New feature or request minor New functionality with at most minor breaking changes labels Feb 22, 2024
@kubaceg kubaceg requested a review from labtom February 29, 2024 09:00
labtom
labtom requested changes Feb 29, 2024
View reviewed changes
nobl9/resource_budgetadjustment.go Outdated Show resolved Hide resolved
nobl9/resource_budgetadjustment.go Outdated Show resolved Hide resolved
nobl9/resource_budgetadjustment.go Outdated Show resolved Hide resolved
nobl9/resource_budgetadjustment.go Outdated Show resolved Hide resolved
templates/resources/budget_adjustment.md.tmpl Outdated Show resolved Hide resolved
@kubaceg kubaceg requested a review from labtom March 1, 2024 08:02
@kubaceg kubaceg marked this pull request as ready for review March 6, 2024 06:37
labtom
labtom previously approved these changes Mar 6, 2024
View reviewed changes
@nieomylnieja nieomylnieja removed breaking-change Any kind of non-backwards compatible change release-notes labels Mar 11, 2024
nieomylnieja
nieomylnieja requested changes May 6, 2024
View reviewed changes
nobl9/resource_budgetadjustment.go Outdated Show resolved Hide resolved
nobl9/resource_budgetadjustment.go Outdated Show resolved Hide resolved
nieomylnieja
nieomylnieja approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@nieomylnieja nieomylnieja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@kubaceg kubaceg merged commit 41cde93 into main May 14, 2024
5 checks passed
@kubaceg kubaceg deleted the PC-11815-add-support-for-terraform branch May 14, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nieomylnieja nieomylnieja nieomylnieja approved these changes

@labtom labtom labtom left review comments

@skrolikiewicz skrolikiewicz Awaiting requested review from skrolikiewicz skrolikiewicz is a code owner

@daniel-zelazny daniel-zelazny Awaiting requested review from daniel-zelazny daniel-zelazny is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request go Pull requests that update Go code minor New functionality with at most minor breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubaceg @nieomylnieja @labtom @n9-machine-user