go, api: Create a structure API #2338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
qinqon
force-pushed
the
generate-golang-api
branch
18 times, most recently
from
070254a
to
47c365e
Compare
|
Thank you for your contribution! There was no activity in this pull request recently. To avoid pull requests to pile up, an automated process marked this pull request as stale. It will close this pull request if no further activity occurs. The current policy is available at: https://github.com/nmstate/nmstate/blob/base/.github/stale.yml |
stale
bot
added
the
stale
qinqon
force-pushed
the
generate-golang-api
branch
from
47c365e
to
a03e582
Compare
stale
bot
removed
the
stale
qinqon
force-pushed
the
generate-golang-api
branch
7 times, most recently
from
28b0288
to
432fca0
Compare
qinqon
force-pushed
the
generate-golang-api
branch
8 times, most recently
from
e6965f2
to
3b6a2eb
Compare
qinqon
force-pushed
the
generate-golang-api
branch
4 times, most recently
from
6c169cd
to
ee8922d
Compare
qinqon
force-pushed
the
generate-golang-api
branch
5 times, most recently
from
0ae14ed
to
0d8d555
Compare
qinqon
force-pushed
the
generate-golang-api
branch
2 times, most recently
from
617d07a
to
5063b42
Compare
qinqon
force-pushed
the
generate-golang-api
branch
2 times, most recently
from
3e5f72b
to
f44ee0a
Compare
At some scenarios is useful to have a "structured" version of the network_state, this change creates a golang api tested toward examples and stated used at integration tests it also add the kubebuilder tags to be k8s CRD friendly, the api is created using a code generator writen in rust that use the crate "syn" to traverse the rust ast of specific files that contains the nmstate rust interface. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
qinqon
force-pushed
the
generate-golang-api
branch
from
f44ee0a
to
803a171
Compare
|
/hold We are going to move this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some scenarios is useful to have a "structured" version of the
network_state, this change creates a golang api tested toward examples
and stated used at integration tests it also add the kubebuilder tags to
be k8s CRD friendly. The golang code is generated with a rust tool that traverse the AST of specific rust source files.
make generatehas being call.stpproblem, field with same name at same level with different types, for ovs is directly at boolean.