Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omw-1.4.xml to allow OMW 1.4 to be downloaded #176

Merged
merged 2 commits into from Dec 10, 2021

Conversation

tomaarsen
Copy link
Member

Hello!

Pull request overview

  • Add omw-1.4.xml to accompany the new omw-1.4.zip.
  • Add omw-1.4 in index.xml

In #175, we reverted omw back to the original, and created omw-1.4.zip. At the same time, @ekaf made nltk/nltk#2907, which uses omw-1.4 as the main Wordnet resource from now onwards. This preserves compatibility for older versions. See nltk/nltk#2905 for more discussion surrounding OMW and OMW 1.4.

Currently the issue is that nltk/nltk#2907 is unable to download omw-1.4, as this resource is not downloadable:

> python -m nltk.downloader omw-1.4
...
[nltk_data] Error loading omw-1.4: Package 'omw-1.4' not found in
[nltk_data]     index
Error installing package. Retry? [n/y/e]

This is because omw-1.4.xml was missing, and omw-1.4 was missing from index.xml. This PR adds those files.

I would like to ask @goodmami, @fcbond and/or @ekaf to review the packages/corpora/omw-1.4.xml. Currently, it's a near copy of omw.xml, with only the id modified from omw to omw-1.4.

If this is merged, we can move forward with nltk/nltk#2907, which allows us to use OMW 1.4 from the next release onwards.

  • Tom Aarsen

@ekaf
Copy link
Contributor

ekaf commented Dec 9, 2021

It looks good, except that @fcbond mentioned in #171 (comment):

The URL for the project should change to https://omwn.org/, as compling will be retired soon. I plan to start making the new site useful from next week.

@tomaarsen
Copy link
Member Author

@fcbond Do we want to update the webpage parameter from both omw and omw-1.4 to https://omwn.org/ already, or should we keep them as the compling pages for the time being?

Of course, if we opt to keep them as compling for now, then you can always create a PR or ask us to change the webpage value, and it can be changed in no time.

@stevenbird
Copy link
Member

Let's go with the new URL.

@fcbond
Copy link
Contributor

fcbond commented Dec 10, 2021 via email

@tomaarsen
Copy link
Member Author

Glad to see this consensus! I've made the changes. Should be all set now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants