Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to fix the issue raised by @yzhangcs's comment as a follow-up to #3017. In short, when the substitution cost is greater than 2, the path generated by
_edit_dist_backtrace()
still includes substitution. This is incorrect because a deletion followed by an insertion incur a cost of 2, which is lower than substitution, and thus should be preferred over substitution.In the following test case due to @yzhangcs, the current
_edit_dist_backtrace()
gives the following outputAfter the fix it correctly outputs
[(0, 0), (0, 1), (1, 1)]
. I tried to add the test case provided by @yzhangcs, but didn't figure out how. Could the maintainers of NLTK look into this and add this test case?