Make sure dispersion plot spans full text length #3158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Matplotlib autoscales the x-axis based on where hits are found. This may result in an unintuitive visualization of the dispersion which "zooms in" on the portion of the text with hits, failing to represent the preceding and/or following stretches with no hits:
A more intuitive visualization is one where the x-axis always spans the full length of the text. The most straightforward way to achieve this is via
ax.set_xlim(0, len(text) - 1)
, but since this disables autoscaling, it unfortunately also gets rid of the margins added during autoscaling, which add aesthetically pleasing breathing room to the plot:So instead, we can explicitly set the data limits via
ax.dataLim
, and re-apply autoscaling:This is the solution suggested by this PR.