Fix order of words in y-axis of dispersion_plot #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix order of words in y-axis of dispersion_plot
Reverse input words list
|
The two failures are in nltk downloading datasets, maybe some network connection issue? |
|
Looks good! Thanks for this. And I must say that I don't quite know why those two test runs are failing, but I agree that they must be unrelated. |
This was referenced Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input words are reversed to create 'y' ticks but the internal 'words' list is not updated accordingly.
This has been fixed by getting 'words' back from 'word2y', which is sensitive to 'ignore_case'.
If 'words' should not be sensitive to 'ignore_case', then the following should be used instead: