New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update skolemize.py #2999
Open
cestwc
wants to merge
22
commits into
nltk:develop
Choose a base branch
from
cestwc:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update skolemize.py #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a function, richardize (just a name trying to make it not confused with 'simplify' or 'reduce' ), modified from skolemize
@cestwc: it looks like you've duplicated |
i second this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a function,
richardize
(just a name trying to make it not confused withsimplify
or__reduce__
), modified fromskolemize
.The function name does not represent any logician Richard, and maybe the NLTK maintenance party can choose a better name.
The new function changes minimum from
skolemize
, and instead conversion to CNF (which is not equivalent but equisatisfiable to the input FOL expression),richardize(your_expr).equiv(your_expr)
will be True.The motivation of this function is that I did not find
simplify
to work in the way I wished, and for a pretty messy expression, e.g., those with a lot of consecutive negations, the new function can make it neater.