Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synset_from_sense_key() (#2442) #2988

Merged
merged 2 commits into from May 3, 2022
Merged

Conversation

ekaf
Copy link
Contributor

@ekaf ekaf commented Apr 29, 2022

Fix #2442, #2420, #2219 and #2171 by reverting to the synset_from_sense_key() implementation from #2621.

from nltk.corpus import wordnet as wn
print(wn.synset_from_sense_key("first%5:00:00:ordinal:00"))

Synset('first.s.02')

Explanation: PR #2621 originally fixed sense_key-related problems (#2420, #2171, plus #2219 and #2442).
But #2889 has inadvertently introduced a non-functional version of synset_from_sense_key(). This problem could have been discovered earlier by running the tests embedded in the documentation string of synset_from_sense_key().

@stevenbird stevenbird merged commit 4df980d into nltk:develop May 3, 2022
@stevenbird
Copy link
Member

Thanks @ekaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with synset_from_sense_key function to access adjective satellites
2 participants