Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate: deprecate get and set node methods #2900

Merged
merged 6 commits into from Dec 6, 2021
Merged

deprecate: deprecate get and set node methods #2900

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa186a8
deprecate: deprecate get and set node methods
mohanedmashaly21 Dec 2, 2021
f8d7929
fix pre-commit tests
mohanedmashaly21 Dec 2, 2021
d775e1e
add deprecated decorator
mohanedmashaly21 Dec 2, 2021
60e09ba
fix pre-commit tests
mohanedmashaly21 Dec 2, 2021
25ff6d6
fix a typo
mohanedmashaly21 Dec 6, 2021
eaf17b9
Merge branch 'develop' of https://github.com/nltk/nltk into pr/2900
tomaarsen Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions nltk/tree/tree.py
View file
Open in desktop
Expand Up @@ -6,6 +6,7 @@
# Peter Ljunglöf <peter.ljunglof@gu.se>
# Nathan Bodenstab <bodenstab@cslu.ogi.edu> (tree transforms)
# Eric Kafe <kafe.eric@gmail.com> (Tree.fromlist())
# Mohaned mashaly<mohaned.mashaly12@gmail.com> (Deprecating methods)
# URL: <https://www.nltk.org/>
# For license information, see LICENSE.TXT

Expand All @@ -18,6 +19,7 @@
import sys

from nltk.grammar import Nonterminal, Production
from nltk.internals import deprecated

######################################################################
## Trees
Expand Down Expand Up @@ -200,14 +202,13 @@ def __delitem__(self, index):
# ////////////////////////////////////////////////////////////
# Basic tree operations
# ////////////////////////////////////////////////////////////

@deprecated("_get_node() is deprecated, use label() instead")
def _get_node(self):
"""Outdated method to access the node value; use the label() method instead."""
raise NotImplementedError("Use label() to access a node label.")

@deprecated("_set_node() is deprecated, use set_label() instead")
def _set_node(self, value):
"""Outdated method to set the node value; use the set_label() method instead."""
raise NotImplementedError("Use set_label() method to set a node label.")

node = property(_get_node, _set_node)

Expand Down