Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating third party tools to newer versions and removing MaltParser fixed version #2832

Merged
merged 10 commits into from Oct 13, 2021
1 change: 1 addition & 0 deletions AUTHORS.md
Expand Up @@ -280,6 +280,7 @@
- Hiroki Teranishi <https://github.com/chantera>
- Ruben Cartuyvels <https://github.com/rubencart>
- Dalton Pearson <https://github.com/daltonpearson>
- Gavish Poddar <https://github.com/gavishpoddar>

## Others whose work we've taken and included in NLTK, but who didn't directly contribute it:

Expand Down
2 changes: 1 addition & 1 deletion nltk/test/gluesemantics_malt_fixt.py
Expand Up @@ -4,6 +4,6 @@ def setup_module():
from nltk.parse.malt import MaltParser

try:
depparser = MaltParser("maltparser-1.7.2")
depparser = MaltParser("maltparser")
tomaarsen marked this conversation as resolved.
Show resolved Hide resolved
except LookupError as e:
pytest.skip("MaltParser is not available")
8 changes: 4 additions & 4 deletions tools/travis/third-party.sh
Expand Up @@ -8,8 +8,8 @@ pushd ${HOME}
pushd 'third'

# Download nltk stanford dependencies
#stanford_corenlp_package_zip_name=$(curl -s 'https://stanfordnlp.github.io/CoreNLP/' | grep -o 'stanford-corenlp-full-.*\.zip' | head -n1)
stanford_corenlp_package_zip_name="stanford-corenlp-full-2017-06-09.zip"
#stanford_corenlp_package_zip_name=$(curl -s 'https://stanfordnlp.github.io/CoreNLP/history.html' | grep -o 'stanford-corenlp-full-.*\.zip' | head -n1)
tomaarsen marked this conversation as resolved.
Show resolved Hide resolved
stanford_corenlp_package_zip_name="stanford-corenlp-full-2018-10-05.zip"
[[ ${stanford_corenlp_package_zip_name} =~ (.+)\.zip ]]
stanford_corenlp_package_name=${BASH_REMATCH[1]}
if [[ ! -d ${stanford_corenlp_package_name} ]]; then
Expand All @@ -21,7 +21,7 @@ fi


#stanford_parser_package_zip_name=$(curl -s 'https://nlp.stanford.edu/software/lex-parser.shtml' | grep -o 'stanford-parser-full-.*\.zip' | head -n1)
stanford_parser_package_zip_name="stanford-parser-full-2017-06-09.zip"
stanford_parser_package_zip_name="stanford-parser-full-2018-10-17.zip"
[[ ${stanford_parser_package_zip_name} =~ (.+)\.zip ]]
stanford_parser_package_name=${BASH_REMATCH[1]}
if [[ ! -d ${stanford_parser_package_name} ]]; then
Expand All @@ -32,7 +32,7 @@ if [[ ! -d ${stanford_parser_package_name} ]]; then
fi

#stanford_tagger_package_zip_name=$(curl -s 'https://nlp.stanford.edu/software/tagger.shtml' | grep -o 'stanford-postagger-full-.*\.zip' | head -n1)
stanford_tagger_package_zip_name="stanford-postagger-full-2017-06-09.zip"
stanford_tagger_package_zip_name="stanford-postagger-full-2018-10-16.zip"
[[ ${stanford_tagger_package_zip_name} =~ (.+)\.zip ]]
stanford_tagger_package_name=${BASH_REMATCH[1]}
if [[ ! -d ${stanford_tagger_package_name} ]]; then
Expand Down