Cfd plot fix #2323
Closed
Cfd plot fix #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plot function in ConditionalFreqDist was throwing an ImportError because it was trying to import 'plt' from matplotlib which does not exist. Additionally the methods called were still the methods of they pylab submodule and I updated those calls to those of the pyplot submodule. Additionally the if v in self key check would not pass with valid input so I removed it and the function now plots correctly.
Was calling ax.set_xticks which was not displaying the correct labels so I changed it to use the pyplot.xticks method which works correctly with the input that was being given to set_xticks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plot function in ConditionalFreqDist was throwing an ImportError
because it was trying to import 'plt' from matplotlib which does not
exist. Additionally the methods called were still the methods of
they pylab submodule and I updated those calls to those of the pyplot
submodule. Additionally the
if v in selfkey check would not passwith valid input so I removed it and the function now plots correctly.