Fix synset_from_sense_key() (#2442) #2988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2442, #2420, #2219 and #2171 by reverting to the synset_from_sense_key() implementation from #2621.
Explanation: PR #2621 originally fixed sense_key-related problems (#2420, #2171, plus #2219 and #2442).
But #2889 has inadvertently introduced a non-functional version of synset_from_sense_key(). This problem could have been discovered earlier by running the tests embedded in the documentation string of synset_from_sense_key().