Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add min-block-size to select and make the default minimum 44px #2212

Merged
merged 1 commit into from
May 21, 2024

Conversation

Robbert
Copy link
Member

@Robbert Robbert commented May 17, 2024

This is a breaking change for folks who have select components smaller than 44px, should I be more careful?

Het gaat om deze stories:

@Robbert Robbert requested a review from bddjong May 17, 2024 12:35
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
utrecht ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 0:43am

@Robbert
Copy link
Member Author

Robbert commented May 17, 2024

Hm... misschien moeten we ook nog line-height toevoegen nu.
Update: niet nodig

@Robbert Robbert enabled auto-merge (rebase) May 17, 2024 13:32
@Robbert Robbert requested a review from Yolijn May 19, 2024 15:17
@Robbert Robbert merged commit 6de94bf into main May 21, 2024
14 of 15 checks passed
@Robbert Robbert deleted the style/select-min-block-size branch May 21, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants