feat: created the developer nav bar #707
Conversation
.yarn/releases/yarn-1.22.19.cjs
Outdated
There was a problem hiding this comment.
@Ndohjapan please delete this file
.yarnrc
Outdated
There was a problem hiding this comment.
@Ndohjapan please delete this file
| import { Dialog } from '@headlessui/react'; | ||
| import { Bars3Icon, XMarkIcon } from '@heroicons/react/24/outline'; |
There was a problem hiding this comment.
we don't need these packages since we have icons from material UI or chakra - please uninstall these packages
| const [mobileMenuOpen, setMobileMenuOpen] = useState(false); | ||
|
|
||
| return ( | ||
| <div className="bg-white"> |
There was a problem hiding this comment.
we use ChakraUI for this project - please replace all div, a, h1, etc. with their ChakraUI equivalents (Box, Link, Heading, etc.)
|
|
||
| return ( | ||
| <div className="bg-white"> | ||
| <header className="absolute inset-x-0 top-0 z-50"> |
There was a problem hiding this comment.
it's not typical to use the header tag - please refer to the navigation bar that's used on the homepage for inspiration
| ]; | ||
|
|
||
| export default function NewHeader() { | ||
| const [mobileMenuOpen, setMobileMenuOpen] = useState(false); |
There was a problem hiding this comment.
| const [mobileMenuOpen, setMobileMenuOpen] = useState(false); | |
| const [isMobileMenuOpen, setIsMobileMenuOpen] = useState(false); |
| @@ -0,0 +1,81 @@ | |||
| import { | |||
There was a problem hiding this comment.
question: why are you creating a brand new navbar? these are the same options that we have in our existing navbar - couldn't we reuse the navbar that we already have?
There was a problem hiding this comment.
I actually wanted to use the existing nav bar.
However the Figma design is a bit different from it and I thought it was intentional from the design to make that of the developer dashboard different from the main nav bar.
There was a problem hiding this comment.
hmm, let's confirm with David if we can update the Figma designs so they match our current navbar, or if he wants to update our existing navbar to match his newer designs
i think having two navbars at right now might be a bit much for us to maintain!
ijemmao
force-pushed
the
io/developer-dashboard
branch
6 times, most recently
from
fb6ed0f
to
1f29c6c
Compare
ijemmao
force-pushed
the
io/developer-dashboard
branch
2 times, most recently
from
c9ef97f
to
8d08544
Compare
Describe your changes
Created the Navbar for developer dashbaord
Issue ticket number and link
#702
Screenshots (if appropriate):