New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: strict mode ON #676

Open

dhruvdabhi101 wants to merge 2 commits into nkowaokwu:master from dhruvdabhi101:strict-mode-on

dhruvdabhi101 commented Jun 21, 2023

Describe your changes

Made strict to true in tsconfig.json file

Issue ticket number and link

Closed #663

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):


          chore: strict mode ON

563294b

Collaborator

ijemmao commented Jun 21, 2023

@dhruvdabhi101 can you confirm that this change doesn't break our testing pipeline by doing the following:

Locally run yarn build
Locally run yarn test
Attach screenshots of passing tests in this PR description


          Merge branch 'master' into strict-mode-on

9554bd3

Collaborator

ijemmao commented Jun 22, 2023

@dhruvdabhi101 looks like the CI is failing due to a types error - https://github.com/nkowaokwu/igbo_api/actions/runs/5340477169/jobs/9680335276?pr=676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment