fix: use name instead of displayName when updating developer

nkowaokwu · May 5, 2024 · 1407a0b · 1407a0b
1 parent 8d08544
commit 1407a0b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/src/controllers/developers/__tests__/developers.test.ts b/src/controllers/developers/__tests__/developers.test.ts
@@ -59,7 +59,7 @@ describe('developers', () => {
   });
 
   it('puts a developer', async () => {
-    const userData = { email: 'email', firebaseId: 'firebaseId', displayName: 'name' };
+    const userData = { email: 'email', firebaseId: 'firebaseId', name: 'name' };
     const req = requestFixture({ body: userData });
     const res = responseFixture();
     const next = nextFunctionFixture();

diff --git a/src/controllers/developers/index.ts b/src/controllers/developers/index.ts
@@ -114,12 +114,7 @@ export const putDeveloper: MiddleWare = async (req, res, next) => {
 
   try {
     return res.send(await putDeveloperHelper({ query: { _id: id }, data: req.body }));
-  } catch (err: any) {
-    // TODO: write test to make sure that when there's no developer, the postDeveloper method
-    // gets called
-    if (err.message === 'No developer to update') {
-      return postDeveloper(req, res, next);
-    }
+  } catch (err) {
     return next(err);
   }
 };

diff --git a/src/middleware/validateUpdateDeveloperBody.ts b/src/middleware/validateUpdateDeveloperBody.ts
@@ -4,7 +4,7 @@ import { MiddleWare } from '../types';
 const developersJoiSchema = Joi.object().keys({
   firebaseId: Joi.string().required(),
   email: Joi.string().allow('', null).optional(),
-  displayName: Joi.string().allow('', null).optional(),
+  name: Joi.string().allow('', null).optional(),
 });
 
 const validateUpdateDeveloperBody: MiddleWare = (req, res, next) => {

diff --git a/src/pages/APIs/DevelopersAPI.ts b/src/pages/APIs/DevelopersAPI.ts
@@ -55,7 +55,7 @@ export const putDeveloper = async (user: Partial<User>) => {
     data: {
       firebaseId: user.uid,
       email: user.email,
-      displayName: user.displayName,
+      name: user.displayName,
     },
   });