Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: move entry from #884 from 0.11.0 to [Unreleased] #973

Merged
merged 1 commit into from Nov 16, 2018

Conversation

mpasternacki
Copy link
Contributor

PR #884 added changelog entry in section for 0.11.0, which has been already released, instead of in the [Unreleased] section (which wasn't present yet). Moved the entry where it belongs.

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. It was in the write place in the original PR, but bors merged it wrong. Let's see if bors can do better this time.

bors r+

bors bot added a commit that referenced this pull request Nov 16, 2018
973: CHANGELOG: move entry from #884 from 0.11.0 to [Unreleased] r=asomers a=mpasternacki

PR #884 added changelog entry in section for 0.11.0, which has been already released, instead of in the [Unreleased] section (which wasn't present yet). Moved the entry where it belongs.

Co-authored-by: Maciej Pasternacki <maciej@3ofcoins.net>
@mpasternacki
Copy link
Contributor Author

Original entry seems to be in section [Unreleased] for 0.11.0, as the commit is dated before the 0.11.0 release. PR has been merged after the release, though, but the entry merged where it was added, at the end of 0.11.0's entries.

@asomers
Copy link
Member

asomers commented Nov 16, 2018

Ahh, that makes sense. My faith in bors is restored. I guess we need a policy of rebasing all PRs after a release.

@bors
Copy link
Contributor

bors bot commented Nov 16, 2018

@bors bors bot merged commit f7e0eab into nix-rust:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants