Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sync (fix #959) #961

Merged
merged 1 commit into from Nov 2, 2018
Merged

Add sync (fix #959) #961

merged 1 commit into from Nov 2, 2018

Conversation

r-darwish
Copy link
Contributor

No description provided.

asomers
asomers requested changes Nov 1, 2018
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add a CHANGELOG entry for this. Also, you don't need #[inline]. The compiler will figure that out for any applications using LTO.

@r-darwish
Copy link
Contributor Author

@asomers done. Thanks for the quick review.

asomers
asomers approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bors r+

bors bot added a commit that referenced this pull request Nov 2, 2018
@bors @r-darwish
Merge #961
5fbdb8a 
961: Add sync (fix #959) r=asomers a=r-darwish



Co-authored-by: Roey Darwish Dror <roey.ghost@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 2, 2018

Build succeeded

@bors bors bot merged commit a37f845 into nix-rust:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-darwish @asomers