Add wrappers for futimens(2) and utimesat(2) #944

jmmv · 2018-09-24T16:56:56Z

Hello again!

Let's see how this looks like. I don't think there is any other way of doing this via the standard library, though I see there is a filetime crate in the Rust nursery to add this missing functionality. Not sure what your policy for adding features into nix is.

asomers · 2018-09-25T15:58:53Z

utimes(2) is obsolete. futimens and utimensat are the newer replacements. So you should be using one of those instead. Or are you working on an OS that doesn't have them?

jmmv · 2018-09-25T16:45:19Z

Why is utimes obsolete? I don't see it documented as such in the manual page (of macOS).

But I can change this to implement the other two calls if you prefer; I'm not bound to using utimes at the moment. Is there anything else major to change?

jmmv · 2018-09-25T16:59:35Z

Grr, except that libc lacks both utimensat and futimens support for macOS. I guess we should fix that first...

jmmv · 2018-09-25T17:06:45Z

Sent PR for libc in rust-lang/libc#1084.

jmmv · 2018-09-25T19:25:42Z

Alright, dependent PR addressed, so updated this one with new wrappers as you proposed.

asomers · 2018-09-25T20:04:47Z

Sigh. It looks like libc needs a PR for FreeBSD, too.

jmmv · 2018-09-25T20:22:26Z

Sent rust-lang/libc#1085 for FreeBSD and DragonFly.

Expose futimens and utimensat on FreeBSD and DragonFly Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944). Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.

jmmv · 2018-09-28T18:26:46Z

Dependent libc change submitted. Forced a push to the PR to trigger another CI run here.

asomers

Apart from that one malformed comment, it LGTM.

src/sys/stat.rs

asomers · 2018-09-29T23:30:27Z

Thanks. But one more thing: please add an entry in CHANGELOG.

jmmv · 2018-09-29T23:36:54Z

CHANGELOG entry added and branch rebased on master to avoid conflicts.

CHANGELOG.md

asomers · 2018-09-30T01:21:36Z

Thanks for your contribution.
bors r+

944: Add wrappers for futimens(2) and utimesat(2) r=asomers a=jmmv Hello again! Let's see how this looks like. I don't think there is any other way of doing this via the standard library, though I see there is a `filetime` crate in the Rust nursery to add this missing functionality. Not sure what your policy for adding features into `nix` is. Co-authored-by: Julio Merino <jmmv@google.com>

bors · 2018-09-30T01:52:22Z

Build succeeded

jmmv · 2018-10-01T00:57:42Z

Ugh, I wasn't expecting the original message in the PR review thread would appear in the commit message :-( I guess I know for next time.

jmmv · 2018-10-01T10:13:21Z

And more: I just found out the hard way that futimens and utimesat are not available on macOS 10.12 or below. Not that I care much about supporting that old version, but I have to use this version on Travis as it's the only one that allows loading the FUSE kext.

What's the policy for nix regarding OS supported versions?

asomers · 2018-10-01T14:00:36Z

Nix doesn't attempt to guarantee consistent features across different OSes and versions, since its objective is simply to expose OS functionality. If a Nix function returns ENOSYS on older OSes, that's fine.

jmmv · 2018-10-01T14:15:22Z

But then, would it be OK to also implement utimes? This deprecated function is going to exist pretty much everywhere, and for my specific use case, it's sufficient. Otherwise, in those systems where these functions return ENOSYS, we need to fall back to raw libc calls...

asomers · 2018-10-01T14:16:54Z

Yeah, I think that's ok.

PR nix-rust#944 added wrappers for the more-modern futimens(2) and utimesat(2), but unfortunately these APIs are not available on old-ish systems. In particular, macOS Sierra and below don't implement them, making the new APIs unusable. Whether we should care about such "old" systems is debatable, but the problem is that, at the moment, this is the only macOS version usable on Travis to test kexts and, thus, to test FUSE file systems.

946: Add a wrapper for utimes(2) r=asomers a=jmmv PR #944 added wrappers for the more-modern futimens(2) and utimesat(2), but unfortunately these APIs are not available on old-ish systems. In particular, macOS Sierra and below don't implement them, making the new APIs unusable. Whether we should care about such "old" systems is debatable, but the problem is that, at the moment, this is the only macOS version usable on Travis to test kexts and, thus, to test FUSE file systems. Co-authored-by: Julio Merino <julio@meroh.net>

PR nix-rust#944 added wrappers for the more-modern futimens(2) and utimesat(2), but unfortunately these APIs are not available on old-ish systems. In particular, macOS Sierra and below don't implement them, making the new APIs unusable. Whether we should care about such "old" systems is debatable, but the problem is that, at the moment, this is the only macOS version usable on Travis to test kexts and, thus, to test FUSE file systems. This should have been part of PR nix-rust#946, which added a wrapper for utimes(2) following this same rationale, but missed lutimes(2) because I simply didn't notice it existed.

967: Add a wrapper for lutimes(2) r=asomers a=jmmv PR #944 added wrappers for the more-modern futimens(2) and utimesat(2), but unfortunately these APIs are not available on old-ish systems. In particular, macOS Sierra and below don't implement them, making the new APIs unusable. Whether we should care about such "old" systems is debatable, but the problem is that, at the moment, this is the only macOS version usable on Travis to test kexts and, thus, to test FUSE file systems. This should have been part of PR #946, which added a wrapper for utimes(2) following this same rationale, but missed lutimes(2) because I simply didn't notice it existed. Co-authored-by: Julio Merino <julio@meroh.net>

PR nix-rust#944 added wrappers for the more-modern futimens(2) and utimesat(2), but unfortunately these APIs are not available on old-ish systems. In particular, macOS Sierra and below don't implement them, making the new APIs unusable. Whether we should care about such "old" systems is debatable, but the problem is that, at the moment, this is the only macOS version usable on Travis to test kexts and, thus, to test FUSE file systems. This should have been part of PR nix-rust#946, which added a wrapper for utimes(2) following this same rationale, but missed lutimes(2) because I simply didn't notice it existed.

jmmv force-pushed the utimes branch from 63b6851 to 539f9f1 Compare September 25, 2018 00:55

jmmv force-pushed the utimes branch from 539f9f1 to 1089c08 Compare September 25, 2018 19:25

jmmv changed the title ~~Add a wrapper for utimes(2)~~ Add wrappers for futimens(2) and utimesat(2) Sep 25, 2018

jmmv mentioned this pull request Sep 25, 2018

Expose futimens and utimensat on FreeBSD and DragonFly rust-lang/libc#1085

Merged

jmmv force-pushed the utimes branch from 1089c08 to 313f857 Compare September 28, 2018 18:26

asomers approved these changes Sep 29, 2018

View reviewed changes

src/sys/stat.rs Outdated Show resolved Hide resolved

jmmv force-pushed the utimes branch from 313f857 to 0f2a5bc Compare September 29, 2018 20:18

jmmv force-pushed the utimes branch 2 times, most recently from 717debc to 2be6bec Compare September 29, 2018 23:36

asomers reviewed Sep 30, 2018

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

Add wrappers for futimens(2) and utimesat(2)

886c76c

jmmv force-pushed the utimes branch from 2be6bec to 886c76c Compare September 30, 2018 01:09

bors bot merged commit 886c76c into nix-rust:master Sep 30, 2018

jmmv deleted the utimes branch September 30, 2018 01:52

jmmv mentioned this pull request Oct 2, 2018

Add a wrapper for utimes(2) #946

Merged

jmmv mentioned this pull request Nov 5, 2018

Add a wrapper for lutimes(2) #967

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add wrappers for futimens(2) and utimesat(2) #944

Add wrappers for futimens(2) and utimesat(2) #944

jmmv commented Sep 24, 2018

asomers commented Sep 25, 2018

jmmv commented Sep 25, 2018

jmmv commented Sep 25, 2018

jmmv commented Sep 25, 2018

jmmv commented Sep 25, 2018

asomers commented Sep 25, 2018 •

edited

jmmv commented Sep 25, 2018

jmmv commented Sep 28, 2018

asomers left a comment

asomers commented Sep 29, 2018

jmmv commented Sep 29, 2018

asomers commented Sep 30, 2018

bors bot commented Sep 30, 2018

jmmv commented Oct 1, 2018

jmmv commented Oct 1, 2018

asomers commented Oct 1, 2018

jmmv commented Oct 1, 2018

asomers commented Oct 1, 2018

Add wrappers for futimens(2) and utimesat(2) #944

Add wrappers for futimens(2) and utimesat(2) #944

Conversation

jmmv commented Sep 24, 2018

asomers commented Sep 25, 2018

jmmv commented Sep 25, 2018

jmmv commented Sep 25, 2018

jmmv commented Sep 25, 2018

jmmv commented Sep 25, 2018

asomers commented Sep 25, 2018 • edited

jmmv commented Sep 25, 2018

jmmv commented Sep 28, 2018

asomers left a comment

Choose a reason for hiding this comment

asomers commented Sep 29, 2018

jmmv commented Sep 29, 2018

asomers commented Sep 30, 2018

bors bot commented Sep 30, 2018

Build succeeded

jmmv commented Oct 1, 2018

jmmv commented Oct 1, 2018

asomers commented Oct 1, 2018

jmmv commented Oct 1, 2018

asomers commented Oct 1, 2018

asomers commented Sep 25, 2018 •

edited