Added sigaction_is_default(), sigaction_is_ignore(), and sigaction_current() functions
#2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 13, 2023 20:10
Multiple tests run within the same process in an indeterminate order. Restore the signal handler at the end of the test so other tests aren't affected.
Provide a way to query the currently installed sigaction. The decision to add `sigaction_current()` instead of just exposing the `sigaction_inner()` function was to avoid any confusion over the semantics of passing in a `None` `sigaction` argument (eg: someone thinking that it meant remove or reset the action). This builds towards nix-rust#2172.
Provide safe mechanisms to determine whether a signal's action is the default or ignore. This covers the majority of real-world calls to `sigaction()` with a NULL action without needing any unsafe code. Fixes nix-rust#2172.
This was referenced Nov 14, 2023
|
I've also added a (loosely) related/complementary proposal to add safe functions to ignore and restore signals' actions in #2191. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Provide safe mechanisms to determine whether a signal's action is the default or ignore.
This covers the majority of real-world calls to
sigaction()with a NULL action without needing any unsafe code.Provide an unsafe way to query the currently installed sigaction.
The decision to add
sigaction_current()instead of just exposing the (new)sigaction_inner()function was to avoid any confusion over the semantics of passing in aNonesigactionargument (eg: someone thinking that it meant remove or reset the action).This closes #2172
Checklist:
CONTRIBUTING.md