Add IPV6_PKTINFO, Correct documentationn for IPV6_RECVPKTINFO #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
SteveLauC
requested changes
Nov 29, 2023
Comment on lines
+877
to
+885
| #[cfg(any( | ||
| target_os = "android", | ||
| target_os = "freebsd", | ||
| target_os = "ios", | ||
| target_os = "linux", | ||
| target_os = "macos", | ||
| target_os = "netbsd", | ||
| target_os = "openbsd", | ||
| ))] |
There was a problem hiding this comment.
This symbol seems to be available on DragonFlyBSD and other Apple targets, if we add them, then this can be changed to:
Suggested change
| #[cfg(any( | |
| target_os = "android", | |
| target_os = "freebsd", | |
| target_os = "ios", | |
| target_os = "linux", | |
| target_os = "macos", | |
| target_os = "netbsd", | |
| target_os = "openbsd", | |
| ))] | |
| #[cfg(any(linux_android, bsd))] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPV6_PKTINFOwas missing fromsockoptso I added it and the documentation forIPV6_RECVPKTINFOincorrectly said it was enabling the flag forIPV6_PKTINFOso I corrected that.