New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend type of service/traffic class socket options #2081
base: master
Are you sure you want to change the base?
Conversation
This looks good, but would it be possible to add a test? |
3eee6b8
to
3833746
Compare
Added tests and rebased on master. The Linux aarch64 failure seems to be a transient network error. |
Hi, sorry for the late reply. Something at Nix has changed so that this PR needs an update:
|
3833746
to
d742537
Compare
Thanks for reviewing. Changes applied. |
), | ||
None => return, | ||
}; | ||
let receive = socket( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be easier to write the test to use socketpair
instead of to create two sockets and connect them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied this pattern from nearby tests. Might be better to leave it as is for the sake of consistency?
d742537
to
bcf6269
Compare
bcf6269
to
c17d30a
Compare
No description provided.