Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add syncfs on linux #1833

Merged
merged 1 commit into from Oct 8, 2022
Merged

add syncfs on linux #1833

merged 1 commit into from Oct 8, 2022

Conversation

SteveLauC
Copy link
Member

Fixes #1818

Change has not been added to CHANGELOG.md, will add it when #1831 is merged, or there will be a merge conflict

@rtzoeller
Copy link
Collaborator

Changes look good to me, other than the CHANGELOG update. Although I did need a refresher on the difference between syncfs and fsync.

@SteveLauC
Copy link
Member Author

other than the CHANGELOG update.

CHANGELOG.md updated and commits squashed

Although I did need a refresher on the difference between syncfs and fsync.

  • fsync: file synchronization
    This is file oriented and writes the modification in units of files.
  • syncfs: synchronize file system
    This is file system (partition) oriented and writes the modification in units of the file system, and thus more expensive.

For a single file system, calling syncfs(fd) is equivalent to calling fsync(fd) on every file residing on that file system.

@SteveLauC
Copy link
Member Author

CI Redox x86_64 failed, seems unrelated to this pr

@rtzoeller
Copy link
Collaborator

The redox failure is due to some new clippy lints being more aggressive. I'm working on a fix.

rtzoeller
rtzoeller approved these changes Oct 8, 2022
View reviewed changes
Copy link
Collaborator

@rtzoeller rtzoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 8, 2022

Build succeeded:

@bors bors bot merged commit 0eebf19 into nix-rust:master Oct 8, 2022
@SteveLauC SteveLauC deleted the syncfs-on-linux branch October 8, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtzoeller rtzoeller rtzoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API request: Linux-specific syncfs(2)
2 participants
@SteveLauC @rtzoeller