Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add memfd for target_os = "android" #1773

Merged
merged 1 commit into from Jul 25, 2022
Merged

Add memfd for target_os = "android" #1773

merged 1 commit into from Jul 25, 2022

Conversation

flxo
Copy link
Contributor

@flxo flxo commented Jul 25, 2022

Memory fds (memfd) are implemented and exported by Androids bionic.
Export the memfd module if the target os is android.

https://cs.android.com/android/platform/superproject/+/master:bionic/libc/include/sys/mman.h;drc=23c7543b8e608ebcbb38b952761b54bb56065577;bpv=1;bpt=1;l=182

@flxo
Add memfd for target_os = "android"
e357d60 
Memory fds (`memfd`) are implemented and exported by Androids bionic.
Export the `memfd` module if the target os is `android`.

https://cs.android.com/android/platform/superproject/+/master:bionic/libc/include/sys/mman.h;drc=23c7543b8e608ebcbb38b952761b54bb56065577;bpv=1;bpt=1;l=182
@flxo flxo marked this pull request as ready for review July 25, 2022 07:01
asomers
asomers approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 25, 2022

Build succeeded:

@bors bors bot merged commit 981df92 into nix-rust:master Jul 25, 2022
@detly detly mentioned this pull request Jul 26, 2022
Merged
@flxo flxo deleted the pr-memfd branch July 26, 2022 05:48
bors bot added a commit that referenced this pull request Jul 26, 2022
@bors @detly
Merge #1774
f8794dd 
1774: Fix typo guarding memfd export on android. r=asomers a=detly

Extremely minor but crucial typo on import guard from #1773. `@flxo` 

Co-authored-by: Jason Heeris <jason.heeris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flxo @asomers