Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a buffer overflow in sys::socket::recvfrom #1763

Merged
merged 1 commit into from Jul 14, 2022
Merged

Fix a buffer overflow in sys::socket::recvfrom #1763

merged 1 commit into from Jul 14, 2022

Conversation

asomers
Copy link
Member

@asomers asomers commented Jul 14, 2022

IPv4 and stream sockets are unaffected, but for datagram sockets of
other address types libc::recvfrom might overwrite part of the stack.

Fixes #1762

@asomers asomers requested a review from rtzoeller July 14, 2022 17:12
@asomers
Fix a buffer overflow in sys::socket::recvfrom
e0e768e 
IPv4 and stream sockets are unaffected, but for datagram sockets of
other address types libc::recvfrom might overwrite part of the stack.

Fixes nix-rust#1762
@asomers
Copy link
Member Author

asomers commented Jul 14, 2022

bors r=posborne

@bors
Copy link
Contributor

bors bot commented Jul 14, 2022

Build succeeded:

@bors bors bot merged commit 2556b78 into nix-rust:master Jul 14, 2022
@rtzoeller rtzoeller added this to the 0.24.2 milestone Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posborne posborne posborne approved these changes

@rtzoeller rtzoeller Awaiting requested review from rtzoeller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.2
Development

Successfully merging this pull request may close these issues.

memory corruption in socket::recvfrom()
3 participants
@asomers @posborne @rtzoeller