Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing DontRoute SockOpt #1752

Merged
merged 2 commits into from Jul 10, 2022
Merged

Add missing DontRoute SockOpt #1752

merged 2 commits into from Jul 10, 2022

Conversation

leoleoasd
Copy link
Contributor

I'm not sure, but according to unix standard, SO_DONTROUTE should appear in all unix systems.
Does this need a test?

asomers
asomers requested changes Jul 10, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't need a test. But could you please add a CHANGELOG entry?

@leoleoasd leoleoasd requested a review from asomers July 10, 2022 04:19
@asomers
Copy link
Member

asomers commented Jul 10, 2022

You need to rebase to fix the CI failures.

asomers
asomers approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 10, 2022

Build succeeded:

@bors bors bot merged commit d09c297 into nix-rust:master Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leoleoasd @asomers