Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SockaddrStorage::{as_link_addr, as_link_addr_mut} on Linux. #1729

Merged
merged 1 commit into from Jun 1, 2022
Merged

Enable SockaddrStorage::{as_link_addr, as_link_addr_mut} on Linux. #1729

merged 1 commit into from Jun 1, 2022

Conversation

asomers
Copy link
Member

@asomers asomers commented May 31, 2022

This was an oversight from #1684.

Fixes #1728

@asomers asomers requested a review from rtzoeller May 31, 2022 16:04
rtzoeller
rtzoeller approved these changes May 31, 2022
View reviewed changes
Copy link
Collaborator

@rtzoeller rtzoeller left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asomers given that the next minor release of nix will have the aio breaking changes, do you think it's worth backporting this change to a 0.24.2 release? I don't mind doing the legwork.

bors r+

@asomers
Copy link
Member Author

asomers commented Jun 1, 2022

I do think that a patch release would be worthwhile. But there's one other issue that ought to go into it. I'll go ping the reporter again.

@asomers asomers added this to the 0.24.2 milestone Jun 1, 2022
@bors
Copy link
Contributor

bors bot commented Jun 1, 2022

Build succeeded:

@bors bors bot merged commit 5dedbc7 into nix-rust:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtzoeller rtzoeller rtzoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.2
Development

Successfully merging this pull request may close these issues.

No way to obtain a LinkAddr on Linux
2 participants
@asomers @rtzoeller