Add ptrace::read_user and ptrace::write_user #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbaksalyar
force-pushed
the
ptrace-user
branch
2 times, most recently
from
5281b30
to
3fc915c
Compare
|
Hmm, the |
rtzoeller
reviewed
May 14, 2022
CHANGELOG.md
Outdated
| @@ -64,6 +64,7 @@ This project adheres to [Semantic Versioning](https://semver.org/). | |||
| - Added `Ipv6DontFrag` for android, iOS, linux and macOS. | |||
| - Added `IpDontFrag` for iOS, macOS. | |||
| (#[1692](https://github.com/nix-rust/nix/pull/1692)) | |||
| - Added `ptrace::read_user` and `ptrace::write_user` for Linux. | |||
There was a problem hiding this comment.
Can you rebase such that this is in the latest unreleased section (the current changes it's near are part of the 0.24.0 release) and also add a link back to this PR, like the other items in the CHANGELOG?
rtzoeller
reviewed
May 14, 2022
nbaksalyar
force-pushed
the
ptrace-user
branch
2 times, most recently
from
6620faa
to
4930d37
Compare
rtzoeller
reviewed
May 15, 2022
test/sys/test_ptrace.rs
Outdated
| // Find the offset of `user.regs.rax` (or `eax` for x86) | ||
| let user_struct = std::mem::MaybeUninit::<libc::user>::uninit(); | ||
| let user_struct_ptr = user_struct.as_ptr(); | ||
| let rax_offset = get_rax_offset(user_struct_ptr) as usize - user_struct_ptr as usize; |
There was a problem hiding this comment.
Nix already depends on the memoffset crate conditionally, and we can use it in our tests (may need to update Cargo.toml to do so).
It should be possible to use memoffset::offset_of to simplify this.
There was a problem hiding this comment.
Great suggestion, that should be done 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.