Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/stat: add a safe wrapper for mknodat(2) #1473

Merged
merged 1 commit into from Jul 29, 2021
Merged

sys/stat: add a safe wrapper for mknodat(2) #1473

merged 1 commit into from Jul 29, 2021

Conversation

lucab
Copy link
Contributor

@lucab lucab commented Jul 22, 2021

asomers
asomers requested changes Jul 24, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. How about a test?

@lucab lucab force-pushed the ups/mknodat branch 3 times, most recently from 004ca1b to 555d3e2 Compare July 28, 2021 12:19
@lucab
Copy link
Contributor Author

lucab commented Jul 28, 2021

I was hoping to copy+adjust the mknod test, but there was none; I thus added a basic test for both.
I initially started writing a chardev test, but then realized it could be problematic on nodev mountpoints so I went for a simpler regular-file one instead (which is not supported on freebsd though).
Also rebased on current master to solve changelog conflict. CI is green. This is ready for another review pass now.

asomers
asomers approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bors r+

@bors bors bot merged commit 3c45e08 into nix-rust:master Jul 29, 2021
@bors
Copy link
Contributor

bors bot commented Jul 29, 2021

Build succeeded:

@lucab lucab deleted the ups/mknodat branch July 29, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otavio otavio otavio approved these changes

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucab @otavio @asomers