Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pthread_kill #1472

Merged
merged 1 commit into from Jul 24, 2021
Merged

Add pthread_kill #1472

merged 1 commit into from Jul 24, 2021

Conversation

mkroening
Copy link
Contributor

This adds pthread_kill, following the design of killpg.

What do you think?

@mkroening mkroening force-pushed the pthread_kill branch 2 times, most recently from eac7bf1 to d150ca9 Compare July 19, 2021 17:00
@mkroening mkroening marked this pull request as ready for review July 19, 2021 17:01
asomers
asomers requested changes Jul 24, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. But could you move it from sys/signal.rs to sys/pthread.rs ?

@mkroening
Copy link
Contributor Author

Sure! Done. 👍

@mkroening mkroening requested a review from asomers July 24, 2021 20:57
asomers
asomers approved these changes Jul 24, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 24, 2021

Build succeeded:

@bors bors bot merged commit e1351ab into nix-rust:master Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkroening @asomers