Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't implement Clone on Dir, SignalFd, and PtyMaster #1382

Merged
merged 1 commit into from Feb 13, 2021
Merged

Don't implement Clone on Dir, SignalFd, and PtyMaster #1382

merged 1 commit into from Feb 13, 2021

Commits on Feb 7, 2021

  1. Don't implement Clone on Dir, SignalFd, and PtyMaster 

    Since they close their file descriptors on Drop, it's almost impossible
to use Clone without creating a double-close situation.

Also, check for EBADF in SignalFd::drop and Dir::drop.
    @asomers
    asomers committed Feb 7, 2021
    Copy the full SHA
    c9cb83a View commit details
    Browse the repository at this point in the history