Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy cleanup #1244

Merged
merged 9 commits into from Jul 3, 2020
Merged

Clippy cleanup #1244

merged 9 commits into from Jul 3, 2020

Commits on Jun 27, 2020

  1. Fix an unaligned pointer read in Inotify::read_events 

    Reported-by: Clippy
    @asomers
    asomers committed Jun 27, 2020
    Copy the full SHA
    f4fc06d View commit details
    Browse the repository at this point in the history

  2. Make sys::socket::sockaddr_storage a safe function 

    It already fully validated its arguments, so there's no need for it to
be `unsafe`.
    @asomers
    asomers committed Jun 27, 2020
    Copy the full SHA
    d6f0471 View commit details
    Browse the repository at this point in the history

  3. implement Default for CpuSet.

    @asomers
    asomers committed Jun 27, 2020
    Copy the full SHA
    6f68bfd View commit details
    Browse the repository at this point in the history

  4. implement Default for UnixCredentials on Linux

    @asomers
    asomers committed Jun 27, 2020
    Copy the full SHA
    729e782 View commit details
    Browse the repository at this point in the history

  5. Prefer to pass Inotify by value instead of by reference 

    It's small and `Copy`, so pass by value is more efficient.  This is
technically a breaking change, but most code should compile without
changes.
    @asomers
    asomers committed Jun 27, 2020
    Copy the full SHA
    e6e25ec View commit details
    Browse the repository at this point in the history

  6. Make Errno::clear safe 

    All it does is assign a value to a thread-local int.  There's nothing
unsafe about that.
    @asomers
    asomers committed Jun 27, 2020
    Copy the full SHA
    3094772 View commit details
    Browse the repository at this point in the history

  7. Make SockAddr::as_ffi_pair safe 

    It was only marked unsafe because it did a pointer cast, but that
particular pointer cast is always allowed by C.
    @asomers
    asomers committed Jun 27, 2020
    Copy the full SHA
    af45859 View commit details
    Browse the repository at this point in the history

  8. misc clippy cleanup

    @asomers
    asomers committed Jun 27, 2020
    Copy the full SHA
    46a8698 View commit details
    Browse the repository at this point in the history

  9. Fix an "unused import" warning on musl

    @asomers
    asomers committed Jun 27, 2020
    Copy the full SHA
    27d39b2 View commit details
    Browse the repository at this point in the history