Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ipv{4,6}PacketInfo support to ControlMessage for send{m,}msg. #1222
Add Ipv{4,6}PacketInfo support to ControlMessage for send{m,}msg. #1222
Changes from all commits
78347d1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, the CI systems as well as most dev systems won't have multiple IP addresses. But if you really want to make a great demonstration of the feature, you could add a binary in the examples/ directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think a good demo here is particularly useful. These are low level APIs that people shouldn't be using directly. Somewhere there should be a crate that abstracts over all of this and provides something like
set_local_address()
and figures out what the correct underlying implementation to use (of which these are only one implementation). For example, for FreeBSD,Ipv6PacketInfo
is the correct answer, but there's a different solution for IPv4.I just thought I'd document why the test seems to be particularly inane. The test should be useful, if anything goes wrong, the kernel will reject it and the test will catch that.