Make FsType's raw type public #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's certainly a real problem. I think this solution is fair. But could you please add a CHANGELOG entry? Also, we would appreciate PRs that add any missing values. |
MikailBag
force-pushed
the
master
branch
2 times, most recently
from
1d686eb
to
6b9bed4
Compare
|
Thanks for review! |
|
Sorry, but you'll need to rebase. |
|
Done |
bors bot
added a commit
that referenced
this pull request
Feb 13, 2020
1187: Make FsType's raw type public r=asomers a=MikailBag # Motivation Currently, `FsType` API is limited. In fact, only operation is supports is comparison with one of well-known IDs. But: * This list is incomplete. For example, it misses cgroupfs and cgroup2fs. * This approach doesn't work with custom FSs. Co-authored-by: Mikail Bagishov <bagishov.mikail@yandex.ru>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently,
FsTypeAPI is limited. In fact, only operation is supports is comparison with one of well-known IDs.But: