Skip to content

Commit

Permalink
Merge #927
Browse files Browse the repository at this point in the history
927: Enable the select tests on powerpc and mips r=asomers a=jonas-schievink

They pass at least on my machine with QEMU, so the underlying bugs might
have been fixed.

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
  • Loading branch information
bors[bot] and jonas-schievink committed Jul 12, 2018
2 parents c1ee0d0 + b572415 commit 237ec7b
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions src/sys/select.rs
Expand Up @@ -273,14 +273,7 @@ mod tests {
assert_eq!(set.highest(), Some(7));
}

// powerpc-unknown-linux-gnu currently fails on the first `assert_eq` because
// `select()` returns a 0 instead of a 1. Since this test has only been run on
// qemu, it's unclear if this is a OS or qemu bug. Just disable it on that arch
// for now.
// FIXME: Fix tests for powerpc and mips
// FIXME: Add a link to an upstream qemu bug if there is one
#[test]
#[cfg_attr(any(target_arch = "powerpc", target_arch = "mips"), ignore)]
fn test_select() {
let (r1, w1) = pipe().unwrap();
write(w1, b"hi!").unwrap();
Expand All @@ -301,7 +294,6 @@ mod tests {
}

#[test]
#[cfg_attr(any(target_arch = "powerpc", target_arch = "mips"), ignore)]
fn test_select_nfds() {
let (r1, w1) = pipe().unwrap();
write(w1, b"hi!").unwrap();
Expand All @@ -322,7 +314,6 @@ mod tests {
}

#[test]
#[cfg_attr(any(target_arch = "powerpc", target_arch = "mips"), ignore)]
fn test_select_nfds2() {
let (r1, w1) = pipe().unwrap();
write(w1, b"hi!").unwrap();
Expand Down

0 comments on commit 237ec7b

Please sign in to comment.