himalaya: adjust module for v1.0.0-beta

[soywod]

Description

Adjust module to match the v1.0.0-beta. I just open the PR as draft (waiting for NixOS/nixpkgs#278088).

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

Maintainer CC

@toastal

[toastal]

Generally looks good (haven’t had a chance to run it). I didn’t expect watch to be added already. My only concern is those cuddled attrset braces with the if statement had me thrown for a loop & I think has a negative impacted on readability.

[soywod]

I didn’t expect watch to be added already

The watch (and notify) were already there before, I just refactored the code to match the new watch API which combines both previous watch (running shell commands) and previous notify (send system notifications).

I agree about the if, I will propose an alternative.

Thank you for your feedback!

[toastal]

@soywod do you have a recent rebase from the default branch atop this?

[soywod]

@soywod do you have a recent rebase from the default branch atop this?

I just rebased my branch.

[toastal]

Going to bed, but I will certainly check tomorrow since my config is obviously broken & I hate emailing on my phone :) -- toastal ไข่ดาว | https://toast.al PGP: 7944 74b7 d236 dab9 c9ef e7f9 5cce 6f14 66d4 7c9e

[erooke]

For whatever it's worth while trying to rebuild my configuration off of this branch I got the following error

error:
       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'home-manager-generation'
         whose name attribute is located at /nix/store/9s5qs4hni9fj88x79iw6im7amv7ghb76-source/pkgs/stdenv/generic/make-derivation.nix:352:7

       … while evaluating attribute 'buildCommand' of derivation 'home-manager-generation'

         at /nix/store/9s5qs4hni9fj88x79iw6im7amv7ghb76-source/pkgs/build-support/trivial-builders/default.nix:98:16:

           97|         enableParallelBuilding = true;
           98|         inherit buildCommand name;
             |                ^
           99|         passAsFile = [ "buildCommand" ]

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: attribute 'accounts' missing

       at /nix/store/kgyb4snyic74z8jyybx1zclh9dk70q8n-source/modules/programs/himalaya.nix:68:33:

           67|         backend = "notmuch";
           68|         notmuch.database-path = config.accounts.email.maildirBasePath;
             |                                 ^
           69|       });

Here is a minimal config which seems to trigger the same breakage:

{...}: {
  home = {
    stateVersion = "24.05";
    username = "test";
    homeDirectory = /home/test;
  };

  accounts.email = {
    maildirBasePath = ".mail";

    accounts.test = {
      primary = true;
      address = "test@mail.com";
      userName = "test@mail.com";
      realName = "Test Testerton";

      notmuch.enable = true;
      himalaya.enable = true;
    };
  };
  programs.notmuch.enable = true;
  programs.himalaya.enable = true;
}

This was using the current nixpkgs-unstable and github:soywod/home-manager/himalaya-v1.0.0-beta. If needed I could supply a flake.lock and flake.nix but that felt like un-needed noise.

[soywod]

For whatever it's worth while trying to rebuild my configuration off of this branch I got the following error

I pushed a fix, it should be good now!

[erooke]

I pushed a fix, it should be good now!

Yup the home manager config now builds on my end! Himalaya seems unhappy with the generated configuration now though.

$ himalaya accounts list

Error: cannot parse config file at "/home/ethan/.config/himalaya/config.toml"

Caused by:
    TOML parse error at line 1, column 1
      |
    1 | [rooke]
      | ^
    unknown variant `notmuch`, expected one of `maildir`, `imap`, `smtp`, `sendmail`    

[soywod]

unknown variant `notmuch`, expected one of `maildir`, `imap`, `smtp`, `sendmail`

The Notmuch backend is not available by default, it requires the "notmuch" cargo feature. The problem is that the Notmuch backend was temporarily be disabled in the "v1.0.0-beta" (which is the one available on nixpkgs-unstable). It has been reactivated in the "v1.0.0-beta.2", which is not yet available on nixpkgs-unstable: <NixOS/nixpkgs#284358> Once the "v1.0.0-beta.2" lands on nixpkgs-unstable, you will be able to adjust your configuration this way: programs.himalaya = { enable = true; package = pkgs.himalaya.override { buildFeatures = ["notmuch"]; }; };

[soywod]

Does it make sense to force the "notmuch" cargo feature from the home-manager module? Something like: home.packages = [ himalaya.package.override { buildFeatures = lib.optional notmuchEnabled "notmuch"; } ]

[erooke]

I personally would like that, maybe just complaining if it's not enabled would also work. I don't know how other hm modules handle it or if it makes sense in the broader picture I'm afraid. Another possibility could be complaining from Himalaya that it was compiled without notmuch support. I did not find the current error very enlightening. Jan 28, 2024 2:39:12 PM Clément DOUIN ***@***.***>:

…

Does it make sense to force the "notmuch" cargo feature from the home-manager module? Something like: home.packages = [ himalaya.package.override { buildFeatures = lib.optional notmuchEnabled "notmuch"; } ] — Reply to this email directly, view it on GitHub[#4839 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ALEG4AKWJCLYN675ZU7COWDYQ2ZO5AVCNFSM6AAAAABBJKDEESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTG4YTKNBWGY]. You are receiving this because you commented. [Tracking image][https://github.com/notifications/beacon/ALEG4AMFDWEUGNEISRY43VLYQ2ZO5A5CNFSM6AAAAABBJKDEESWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTSCD5QU.gif]

[soywod]

@rycee what is the best approach for this kind of situation?

[toastal]

I got the config to build but …

$ himalaya account list
Error: cannot parse config file at "$XDG_CONFIG_HOME/himalaya/config.toml"

Caused by:
    TOML parse error at line 1, column 1
      |
    1 | display-name = "toastal"
      | ^^^^^^^^^^^^^^^^^^^^^^^^
    invalid type: integer `46`, expected struct TomlAccountConfig

[soywod]

I got the config to build but …

There is no way to know the correct location of errors at the moment. It is a known problem, see: - <toml-rs/toml#589 (comment)> - <serde-rs/serde#1183> Could you share your home-manager config as well as the generated TOML?

[toastal]

There is no way to know the correct location of errors at the moment

Well that kinda sucks ha. DM‘d my config on Matrix.

[soywod]

Well that kinda sucks ha.

Yes, I know. It is really frustrating because the issue does not come from Himalaya. But I am working on a work around, I let you know!

[soywod]

I cannot understand why .override does not work from the home manager module but work outside of it: error: attribute 'override' missing

https://github.com/nix-community/home-manager/actions/runs/7702476916/job/20990851373?pr=4839

Edit: somehow the derivation path points to a dummy one: /nix/store/ybh6rq30zqxp2kg0fapimf1rcgpy1vp5-dummy.drv, could it be because a mismatch between my local version of himalaya (beta.2) and the one available on nixpkgs-unstable (beta)? Let's wait for NixOS/nixpkgs#284358.

[toastal]

Wait or not, this does work for me now. Thanks for the help @soywod

[toastal]

Tested new changes.

[rycee]

All good to merge?

[toastal]

It works well enough for me & the beta2 has been merged into nixpkgs.

[rycee]

Cool, thanks! Merged to master now 🙂