Unsubscribe from subscribed address when transaction sending fails #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdanielh
reviewed
May 20, 2024
nibhar
reviewed
May 21, 2024
nibhar
reviewed
May 21, 2024
nibhar
approved these changes
May 21, 2024
Use `Option`s in `AddressSubscription`, because they can be `take`n.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Unsubscribe from a previously subscribed address during tx-sending in the web-client. The address is subscribed to to get notified of the inclusion of the transaction in the chain, then unsubscribed at the end of the function. However,
send_transactionitself can fail, in which case the subscription was not cleaned up.@hrxi This currently is simply a duplication of the code found at the end of the function. Do you know a better way that only defines the logic once and then calls it from both places? Or another means to achieve this same result?
This fixes #2456.
Pull request checklist
clippyandrustfmtwarnings.