Add genesis config hash as extra data to migration ready transaction #2479
+69
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
reviewed
May 17, 2024
Eligioo
force-pushed
the
stefan/migration-ready-tx
branch
from
9910539
to
eaab34c
Compare
jsdanielh
reviewed
May 20, 2024
| "Generating ready transaction" | ||
| ); | ||
| OutgoingTransaction { | ||
| from: validator, | ||
| to: Address::burn_address().to_user_friendly_address(), | ||
| value: 1, //Lunas | ||
| fee: 0, | ||
| data: None, | ||
| data: Some(hash.to_hex()), |
There was a problem hiding this comment.
Which is the reason why we want this in hex rather than the raw hash?
There was a problem hiding this comment.
The PoW RPC specs expects OutgoingTransaction.data to be a String. A raw Blake2bHash doesn't implement that. I could have gone for to_string but to_hex is something we control and have defined which is a little more consistent.
| // Here we filter by current epoch | ||
| // Check if the txn contains extra data and matches our genesis block hash | ||
| if let Some(txn_data) = &txn.data { | ||
| if *txn_data != genesis_config_hex { |
| // Here we filter by the readiness criteria, TBD | ||
| // Check if the txn contains extra data and matches our genesis block hash | ||
| if let Some(txn_data) = &txn.data { | ||
| if *txn_data != genesis_config_hex { |
| let filtered_txns: Vec<TransactionDetails> = transactions | ||
| .into_iter() | ||
| .filter(|txn| { | ||
| // Here we filter by current epoch | ||
| // Check if the txn contains extra data and matches our genesis block hash | ||
| if let Some(txn_data) = &txn.data { |
There was a problem hiding this comment.
I'd suggest to factorize the txn data check in a function to avoid code duplication
| @@ -111,7 +127,16 @@ pub async fn check_validators_ready( | |||
| let filtered_txns: Vec<TransactionDetails> = transactions | |||
| .into_iter() | |||
| .filter(|txn| { | |||
| // Here we filter by the readiness criteria, TBD | |||
| // Check if the txn contains extra data and matches our genesis block hash | |||
| if let Some(txn_data) = &txn.data { | |||
There was a problem hiding this comment.
I'd suggest to factorize the txn data check in a function to avoid code duplication
sisou
changed the title
Eligioo
force-pushed
the
stefan/migration-ready-tx
branch
from
eaab34c
to
d46b911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Pull request checklist
clippyandrustfmtwarnings.