-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused Argon2dHash
and Argon2dHasher
#2444
Conversation
@sisou Am I correct that this function is also not used in the web client? I looked at https://github.com/nimiq/wallet, in the |
I exposed it for backward-compatibility with the PoW client, which also had that method. It's not used in our apps, but doesn't mean someone else doesn't use it. But it's probably a low-usage API. |
Can you maybe expose an Argon2id method on the web-client API as a replacement? |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these are KDF functions, I'd name them as such.
Also, are you able to add rustdocs to the method, explaining their arguments? I wouldn't know what a derived_key_length
is for example.
Argon2 is always a key derivation function, a special kind of hash function. I'm not explicitly mentioning that sha256 is a cryptographic hash function, so intuitively I wouldn't do it for Argon2 either.
I don't know it yet either, but I'll try to find out and document it. |
ac5e018
to
634d07a
Compare
They were only exposed to the web-client, but I couldn't find any reference to this function. The Argon2d/Argon2id implementation in `nimiq_hash::argon2kdf` remain. Fixes #2455 by removing the unused code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
They were only exposed to the web-client, but I couldn't find any reference to this function.
The Argon2d/Argon2id implementation in
nimiq_hash::argon2kdf
remain.Fixes #2455 by removing the unused code.