Update web-client transaction-getter to handle known transactions like the PoW client did #2218
+135
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
force-pushed
the
soeren/wasm-tx-history-compat
branch
from
2371709
to
a140500
Compare
3 tasks
Handle known transactions: re-check them for inclusion, re-send new/pending ones.
jsdanielh
force-pushed
the
soeren/wasm-tx-history-compat
branch
from
a140500
to
83e073c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PoW client by @mar-v-in did some genius handling of known transactions, which can be optionally passed to the client's
getTransactionsByAddressmethod.It, and now this client too, make sure all known transactions are included in the receipts, unconfirmed known transactions are queried again (and confirmed if they are, returned as expired if they have expired), pending or unsent transactions are re-broadcast, known transactions not in the receipts are also rechecked.
Pull request checklist
clippyandrustfmtwarnings.