Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bitflags from 1.3.2 to 2.1.0 #1540

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 6, 2023

Bumps bitflags from 1.3.2 to 2.1.0.

Release notes

Sourced from bitflags's releases.

2.1.0

What's Changed

New Contributors

Full Changelog: bitflags/bitflags@2.0.2...2.1.0

2.0.2

What's Changed

Full Changelog: bitflags/bitflags@2.0.1...2.0.2

2.0.1

What's Changed

New Contributors

Full Changelog: bitflags/bitflags@2.0.0...2.0.1

2.0.0

Major changes

This release includes some major changes over 1.x. If you use bitflags! types in your public API then upgrading this library may cause breakage in your downstream users.

⚠️ Serialization

You'll need to add the serde Cargo feature in order to #[derive(Serialize, Deserialize)] on your generated flags types:

bitflags! {
    #[derive(Serialize, Deserialize)]
    #[serde(transparent)]
    pub struct Flags: T {
        ..
    }
}
</tr></table> 

... (truncated)

Changelog

Sourced from bitflags's changelog.

2.1.0

What's Changed

New Contributors

Full Changelog: bitflags/bitflags@2.0.2...2.1.0

2.0.2

What's Changed

Full Changelog: bitflags/bitflags@2.0.1...2.0.2

2.0.1

What's Changed

New Contributors

Full Changelog: bitflags/bitflags@2.0.0...2.0.1

2.0.0

What's Changed

... (truncated)

Commits
  • 597d407 Merge pull request #334 from KodrAus/cargo/2.1.0
  • c272a0f prepare for 2.1.0 release
  • db4ce36 Merge pull request #331 from EmbarkStudios/main
  • 8ce0072 Ignore clippy lint
  • 038f6e8 Add missing Formatter lifetimes
  • 98b85d5 Merge pull request #330 from KodrAus/fix/missing-docs
  • 7eb912a fix up missing docs for consts within consts
  • 83359a6 Merge pull request #324 from KodrAus/feat/arbitrary
  • ddc975b Merge pull request #328 from KodrAus/chore/docs
  • a963083 update wording of parsing/formatting example
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [bitflags](https://github.com/bitflags/bitflags) from 1.3.2 to 2.1.0.
- [Release notes](https://github.com/bitflags/bitflags/releases)
- [Changelog](https://github.com/bitflags/bitflags/blob/main/CHANGELOG.md)
- [Commits](bitflags/bitflags@1.3.2...2.1.0)

---
updated-dependencies:
- dependency-name: bitflags
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependency rust Pull requests that update Rust code labels Apr 6, 2023
@dependabot dependabot bot requested a review from jsdanielh April 6, 2023 15:09
@sisou
Copy link
Member

sisou commented Apr 21, 2023

Two issues with this:

  1. The behavior of bitflags' serde implementation changed, so that now it serializes to a string for human-readable formats, and to a number only for compact formats. I don't know in how far this is backward-incompatible for Albatross, if the serde serialization is used in the protocol (or if that is handled by Beserial, and serde is only for exposing via RPC or similar, in which case the change is actually good). To keep the old behavior, we'd have to use https://github.com/KodrAus/bitflags-serde-legacy
  2. Beserial derives are blocked by can't use private derive macros bitflags/bitflags#339 and would require a manual implementation.

bitflags v2 release notes with the backward-incompatibility notices: https://github.com/bitflags/bitflags/releases/tag/2.0.0

@sisou sisou force-pushed the dependabot/cargo/bitflags-2.1.0 branch from 4527445 to a4052f6 Compare April 21, 2023 06:29
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 24, 2023

A newer version of bitflags exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@sisou
Copy link
Member

sisou commented May 17, 2023

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 17, 2023

Superseded by #1605.

@dependabot dependabot bot closed this May 17, 2023
@dependabot dependabot bot deleted the dependabot/cargo/bitflags-2.1.0 branch May 17, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants