Move libp2p to a fork and enable CI wasm checks #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdanielh
force-pushed
the
jsdanielh/wasm3
branch
from
23e455f
to
cf96fe7
Compare
viquezclaudio
approved these changes
Jan 26, 2023
Move the `libp2p` dependency to a fork to enable compilation for `wasm` and non-`wasm` targets. This is due to the fact that the `gossipsub` protocol got the `wasm` support dropped in this [PR](libp2p/rust-libp2p#2506).
Add a job in the `build+test` Github Actions workflow for compiling to `wasm` and generating the JS bindings for the `web-client`
jsdanielh
force-pushed
the
jsdanielh/wasm3
branch
from
cf96fe7
to
1a50e74
Compare
Codecov ReportBase: 67.55% // Head: 67.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## albatross #1294 +/- ##
=============================================
- Coverage 67.55% 67.54% -0.01%
=============================================
Files 397 397
Lines 50818 50818
=============================================
- Hits 34331 34327 -4
- Misses 16487 16491 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libp2pdependency to a fork to enable compilation forwasmand non-wasmtargets.This is due to the fact that the
gossipsubprotocol got thewasmsupport dropped in this PR.build+testGithub Actions workflow for compiling towasmand generating the JS bindings for theweb-clientPull request checklist
clippyandrustfmtwarnings.