Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the localization concern, moving to around_action #241

Merged
merged 8 commits into from Oct 15, 2020
Merged

Improve the localization concern, moving to around_action #241

merged 8 commits into from Oct 15, 2020

Commits on Oct 14, 2020

  1. Improve the localization concern, moving to around_action

    @andyduong1920
    andyduong1920 committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    73bc464 View commit details
    Browse the repository at this point in the history

  2. Adding unit test

    @andyduong1920
    andyduong1920 committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    df20b77 View commit details
    Browse the repository at this point in the history

  3. Minor refactor

    @andyduong1920
    andyduong1920 committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    c4956d3 View commit details
    Browse the repository at this point in the history

  4. Minor refactor

    @andyduong1920
    andyduong1920 committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    8b1429e View commit details
    Browse the repository at this point in the history

  5. Adding comment to configuration

    @andyduong1920
    andyduong1920 committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    a3355a1 View commit details
    Browse the repository at this point in the history

  6. Using return first

    @andyduong1920
    andyduong1920 committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    0e06c49 View commit details
    Browse the repository at this point in the history

  7. Using request.headers[:'Accept-Language']

    @andyduong1920
    andyduong1920 committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    1cb5bc7 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Remove unnecessary code

    @andyduong1920
    andyduong1920 committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    39ea1f8 View commit details
    Browse the repository at this point in the history