Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json exports to fix some libs #43

Merged
merged 1 commit into from Nov 2, 2020

Conversation

Graphmaxer
Copy link
Contributor

For some front-end framework like React or Svelte, the package.json file need to be exported. This change is not impacting anything else.

@niksy
Copy link
Owner

niksy commented Nov 2, 2020

Can you point me where this is documented?

@Graphmaxer
Copy link
Contributor Author

Graphmaxer commented Nov 2, 2020

Unfortunately, this is not very well documented. In my case i use svelte and the rollup plugin want to see the package.json to check for a custom svelte field. sveltejs/rollup-plugin-svelte#104

Here a issue in the node repo where multiple libraries use the same mechanism nodejs/node#33460

EDIT: I found the documentation talking about this https://nodejs.org/api/packages.html#packages_package_entry_points

@niksy
Copy link
Owner

niksy commented Nov 2, 2020

Oh wow, I read whole documentation on this but somehow missed this. This really is breaking change. I’m glad they’re discussing about making an exception for package.json.

OK, merging and pushing patch version.

@niksy niksy merged commit 654a7e3 into niksy:master Nov 2, 2020
@Graphmaxer Graphmaxer deleted the patch-1 branch November 2, 2020 11:13
@niksy
Copy link
Owner

niksy commented Nov 2, 2020

@Graphmaxer done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants