Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing functions #6

Closed
wants to merge 1 commit into from

Conversation

Mouvedia
Copy link
Contributor

  • webkit-gradient
  • color-stop
  • from
  • to
  • light-dark

stylelint/stylelint#5960
stylelint/stylelint#7226

- webkit-gradient
- color-stop
- from
- to
- light-dark

stylelint/stylelint#5960
stylelint/stylelint#7226
@niksy
Copy link
Owner

niksy commented Oct 12, 2023

Thanks for the report.

These are resources where we generate list of available CSS functions:

If it’s not there, it would be best to add it there first and then we can update it, similar to how it’s done for newer color functions.

Or, if you can provide additional resource for functions list, I will add it to the parser.

@Mouvedia
Copy link
Contributor Author

Or, if you can provide additional resource for functions list, I will add it to the parser.

https://www.webkit.org/blog/175/introducing-css-gradients/
https://drafts.csswg.org/css-color-5/#light-dark

These are probably not resources for the generator; all I could do is add an additional array to generate-list.js.
These functions are either too old or too new to be documented on developer.mozilla.org.

@niksy
Copy link
Owner

niksy commented Oct 12, 2023

"too old" means that we probably won’t have them anywhere (the blog post is from 2008 and I think there is a small amount of codebases using it), "too new" will be documented eventually and then new list will be generated. In the meantime, you can ignore those functions.

@niksy niksy closed this Oct 12, 2023
@Mouvedia
Copy link
Contributor Author

I disagree with your stance on "too old" functions, that kind of package should be exhaustive IMO; but that's your prerogative as the author and I respect it nonetheless.
Concerning "too new" functions, we will just add exceptions instead of sending PRs from now on.

@niksy
Copy link
Owner

niksy commented Oct 15, 2023

After additional consideration, I’ve decided to add those functions. -webkit-gradient is added manually, and light-dark is now pulled from https://github.com/mdn/browser-compat-data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants