Make phpunit fail on deprecation warnings #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
interessting.. locally I get phpunit fail instead of accepting the error after this PR. I think this means the deprecation warning is not emitted at all in CI |
|
ok, we can see CI failling now. will re-revert the initial fix now |
|
@nikic I think this fix should cover us in the future //cc @samsonasik |
samsonasik
approved these changes
Mar 17, 2024
|
opened a setup-php bug shivammathur/setup-php#827 |
nikic
reviewed
Mar 17, 2024
.github/workflows/main.yml
Outdated
| @@ -49,6 +49,7 @@ jobs: | |||
| with: | |||
| coverage: "none" | |||
| php-version: "${{ matrix.php-version }}" | |||
| ini-values: "error_reporting=2147483647" # E_ALL | |||
There was a problem hiding this comment.
Suggested change
| ini-values: "error_reporting=2147483647" # E_ALL | |
| ini-values: "error_reporting=E_ALL" |
Does this not work?
There was a problem hiding this comment.
using the fix suggested by the setup-php author now
staabm
force-pushed
the
fail
branch
2 times, most recently
from
55393f4
to
df37974
Compare
|
Quite unexpected behavior to me ... guess it's time to go through all my repos and add |
agree. the author agrees too. its planned for the next major, because its a breaking change. |
nikic
pushed a commit
that referenced
this pull request
Mar 17, 2024
(cherry picked from commit 4d36e9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.